search

facebookresearch / audiocraft

Audiocraft is a library for audio processing and generation with deep learning. It features the state-of-the-art EnCodec audio compressor / tokenizer, along with MusicGen, a simple and controllable music generation LM with textual and melodic conditioning.
MIT License
20.61k stars 2.1k forks source link

Uses python -m pip style for installation #177

Closed kushaldas closed 10 months ago

kushaldas commented 1 year ago

Updates the readme to use python -m pip install style for installing python packages. This is what we suggest at upstream to reduce the confusion of which Python interpreter is being used.

See more: https://snarky.ca/why-you-should-use-python-m-pip/

carlthome commented 1 year ago

I wanted to say "not needed because virtualenv" but that link was pretty convincing.

kushaldas commented 1 year ago

I hope one of the maintainers will see and approve. Should not take that much time as it is a much simple PR without code change.

adefossez commented 1 year ago

@kushaldas sorry about that, but due to a bug in HF Transformers, CI is currently failling (not your fault). However, you would have to pull and merge from main and push again before we can accept.

JadeCopet commented 1 year ago

Can you ensure you're up to date with respect to main? There were some issues with Hugging Face Transformers library that required extra dependencies that is now fixed in main. Then we'll be able to merge. Thank you!

kushaldas commented 11 months ago

I updated the PR last week. Commenting as just in case :)

carlthome commented 11 months ago

Some (unrelated?) lint error on CI:

audiocraft/modules/conditioners.py:607: error: Argument 1 to "apply_model" has incompatible type "Union[Tensor, Module]"; expected "Union[BagOfModels, Union[Demucs, HDemucs, HTDemucs]]" [arg-type]

kushaldas commented 10 months ago

Can anyone please tell me what needs to be done here?

kushaldas commented 10 months ago

Woo hoo, can anyone please rerun the CI job and then accept the PR?

kushaldas commented 10 months ago

Will these CI jobs ever finish?

kushaldas commented 10 months ago

@adefossez @JadeCopet can anyone of you please run/kick the CI as required?

carlthome commented 10 months ago

Since @adefossez has left Meta for a new industry lab, I imagine we won't see much reviewing here. Would be nice to know the future of AudioCraft as a package!

kushaldas commented 10 months ago

Who can merge?!!! :)

JadeCopet commented 10 months ago

Hey @kushaldas, sorry for the late response. I had to fix the CI jobs on main, you can merge our main and then we should be good to land this.

JadeCopet commented 10 months ago

Thank you again!

kushaldas commented 10 months ago

Yay!!! Thank you @JadeCopet :)