Use double quotes for better compatibility (REAMDE / ffmpeg)

facebookresearch / audiocraft

Audiocraft is a library for audio processing and generation with deep learning. It features the state-of-the-art EnCodec audio compressor / tokenizer, along with MusicGen, a simple and controllable music generation LM with textual and melodic conditioning.

MIT License

20.5k stars 2.06k forks source link

Use double quotes for better compatibility (REAMDE / ffmpeg) #245

Closed starburst997 closed 12 months ago

starburst997 commented 1 year ago

conda install 'ffmpeg<5' -c conda-forge will results with "The system cannot find the file specified." on Windows.

Using " (double quotes) provide better compatibility and results in the correct behavior on Windows.

JadeCopet commented 12 months ago

Thanks for your contribution! Can you pull from main before we merge this PR? There was some issue with the transformer library that is currently breaking the tests and this is now fixed in main.

starburst997 commented 12 months ago

Of course, no problem, just did