facebookresearch / audiocraft

Audiocraft is a library for audio processing and generation with deep learning. It features the state-of-the-art EnCodec audio compressor / tokenizer, along with MusicGen, a simple and controllable music generation LM with textual and melodic conditioning.
MIT License
20.17k stars 2.01k forks source link

fix typo in diffusion solver config #425

Open hadyelsahar opened 4 months ago

hadyelsahar commented 4 months ago

What?

This is probably an issue with the config file for the diffusion model. The generation sample rate should be added to the generate and not in dataset.generate

This generate.audio params are passed to audio_write functions save audio using ffmpeg in the following line

https://github.com/facebookresearch/audiocraft/blob/69fea8b290ad1b4b40d28f92d1dfc0ab01dbab85/audiocraft/utils/samples/manager.py#L193

Test

python3 -m pdb -c c -m  dora run solver=diffusion/encodec_24khz execute_only=generate continue_from=/path_to_ckpt.th dset=audio/default