search

facebookresearch / beanmachine

A library that allows for inference on probabilistic models
https://beanmachine.org/
MIT License
265 stars 49 forks source link

minibmg: introduce (eventual) replacement nodes that use visitors. #1750

Closed gafter closed 2 years ago

gafter commented 2 years ago

Summary: This is the first step (step 1 below) in a series of refactoring steps that will replace minibmg nodes with a distinct node type for each operations and a visitor mechanism.

  1. Introduce Node2 and Node2Visitor (without tests yet)
  2. Introduce Graph2 using Node2 with json I/O (ditto)
  3. Introduce Tracing2 using Node2 (ditto)
  4. Introduce Eval2 (ditto)
  5. Migrate tests to Node2.
  6. Migrate any remaining pieces to Node2.
  7. Delete Node.h and Node.cpp
  8. Rename Node2 to Node and similarly for other types and files.

Differential Revision: D40390955

facebook-github-bot commented 2 years ago

This pull request was exported from Phabricator. Differential Revision: D40390955