minibmg: fix some small issues detected during review

facebookresearch / beanmachine

A library that allows for inference on probabilistic models

https://beanmachine.org/

MIT License

264 stars 49 forks source link

Closed gafter closed 1 year ago

gafter commented 1 year ago

Summary: Fix two small issues noted during (live, recorded) review of the code:

NodeId should have both hash code and equality defined. Currently only hash code.
Graph::Factory::observe(...) should take ScalarSampleNodeID, not just any ScalarNodeID.

Differential Revision: D40783447

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D40783447