Rename `convert_parents_ids` to `convert_node_ids` and remove `from_id_to_ptr`

facebookresearch / beanmachine

A library that allows for inference on probabilistic models

https://beanmachine.org/

MIT License

264 stars 49 forks source link

Closed rodrigodesalvobraz closed 1 year ago

rodrigodesalvobraz commented 1 year ago

Summary:

Renamed convert_parents_ids to convert_node_ids since it applies to any nodes.
Renamed get_parents_ids to get_nodes_ids since it applies to any nodes.
Replaced from_id_to_ptr by convert_nodes_ids since it was a duplicate, and deleted its definition.
Implemented utilities map2vec and get_index and used them to simplify get_nodes_ids.

Reviewed By: AishwaryaSivaraman

Differential Revision: D40290343

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D40290343