Closed AishwaryaSivaraman closed 1 year ago
Summary: Second gradient of matrix log was computing g''(x) / g(x) + f'(x) * f'(x) instead of g''(x) / g(x) - f'(x) * f'(x) which was causing errors in Overall GEP model.
g''(x) / g(x) + f'(x) * f'(x)
g''(x) / g(x) - f'(x) * f'(x)
Updated the code and corresponding test case.
Differential Revision: D40942050
This pull request was exported from Phabricator. Differential Revision: D40942050
Summary: Second gradient of matrix log was computing
g''(x) / g(x) + f'(x) * f'(x)
instead ofg''(x) / g(x) - f'(x) * f'(x)
which was causing errors in Overall GEP model.Updated the code and corresponding test case.
Differential Revision: D40942050