Open ndmlny-qs opened 1 year ago
@horizon-blue has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
Looks like there're some version updates in yarn.lock
but there's no change in package.json
. Are those updates necessary? I'm asking because due to security reason, we have to check in third-party codes into our internal codebase and load the packages from there instead of downloading them from Yarn/NPM each time we build the library. So every time we introduce a new dependency, we will have to import and check in a bunch of new packages.
Our internal jobs currently fails because it cannot find the node modules that are being used, so I just want to check with you to see if the versions that were in yarn.lock
are sufficient for what we need? If so, then it will save me from the hassle of importing a bunch of new packages every time there's a change to our diagnostic module :)
This is totally my mistake. I was trying out Bokeh 3.0 and did an update with yarn, which is why the lock file changed. I completely forgot to recheckout the lock file and not commit the changes. I'll revert now those changes.
@ndmlny-qs has updated the pull request. You must reimport the pull request before landing.
@horizon-blue has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
Motivation
Continued work on the diagnostics tools.
Changes proposed
pointStatistic.ts
module and placed them in other modules for better structure. Updated all modules that needed to be updated due to the move.updateAxisLabel
to a new module calledutils/plottingUtils.ts
for reuse.webpack.config.js
andtsconfig.json
.viz.py
file to include the new marginal 2d tool.Test Plan
Just visual inspection for now, test to come soon.
Types of changes
Checklist