facebookresearch / beanmachine

A library that allows for inference on probabilistic models
https://beanmachine.org/
MIT License
264 stars 49 forks source link

Remove filterwarning settings for pytest #1827

Closed horizon-blue closed 1 year ago

horizon-blue commented 1 year ago

Motivation

We used to mark all warnings as errors for our pytest runner with the intention that it'll surface deprecation warnings (so that we can fix them as soon as possible). However, with the changes in the project, it becomes difficult for us to keep up with addressing the deprecation warnings, and our CI often fails because of this.

Changes proposed

Remove the setting to turn warnings as errors so that we can leave them there until people have time to address them.

Test Plan

Please provide clear instructions on how the changes were verified. Attach screenshots if applicable.

Types of changes

Checklist

horizon-blue commented 1 year ago

Just created a PR to test out the ShipIt update. Let's see if we can merge this without importing the code internally :).