search

facebookresearch / beanmachine

A library that allows for inference on probabilistic models
https://beanmachine.org/
MIT License
264 stars 49 forks source link

Add goal inference and time series projects #1831

Open jpchen opened 1 year ago

jpchen commented 1 year ago

Motivation

Since there are fewer BM maintainers within Meta, I wanted to open source intern infra projects (by James and Zhen) built on BM for external research and future use. These are all implementations of publicly available papers and contain no internal data. I would like to get this in if tests pass and defer design and functionality questions to a future PR since these things are a bit time sensitive.

Test Plan

I've run this internally, but I'm having issues installing BM on my laptop now (I'll open a separate issue about that) so I'm going to defer to CI's testing. Note that the individual tests for the two experimental projects are not being run as part of our CI suite but since they are experimental, that is not a blocker atm.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

zaxtax commented 1 year ago

Sweet! This looks really cool

jpchen commented 1 year ago

Thanks for the review @ndmlny-qs I'll fix them this week. Good catch on the imports, I now notice pyre is not being run as part of my old linter since I switched devservers.

jpchen commented 1 year ago

I guess this is really a question around legal; since BM is strictly OSS and these projects were previously in BM but not pushed to github, it is more straightforward to make them a part of the project (since BM is already approved for that), and then spun off to their own libraries rather than going through the internal process to oss a new project under Meta's organization which IIRC took months with coordination across multiple pocs. WDYT?