facebookresearch / beanmachine

A library that allows for inference on probabilistic models
https://beanmachine.org/
MIT License
264 stars 49 forks source link

Remove vcpkg requirement and use conda for range-v3 #1835

Closed horizon-blue closed 10 months ago

horizon-blue commented 10 months ago

Motivation

Now that range-v3 is available in conda-forge (https://github.com/conda-forge/staged-recipes/pull/22443), we can simplify the installation and get rid of the need to install vcpkg just to get the range-v3 dependency.

Changes proposed

Test Plan

I have tested and verify that the changes run on my MacOS machine (with Python 3.10). If the CI also pass then we should be good.

Types of changes

Checklist

ndmlny-qs commented 10 months ago

@horizon-blue if there are no other items you want to add to the PR, then let me know if you can do a squash/merge. If not, I think I might be able to fix this for future PRs.

horizon-blue commented 10 months ago

Looks like I am able to squash and merge just fine. Thanks for the review, @ndmlny-qs!