facebookresearch / beanmachine

A library that allows for inference on probabilistic models
https://beanmachine.org/
MIT License
264 stars 49 forks source link

Temporarily disable NNC-compile by default to enable PyTorch 2.0 #1836

Open horizon-blue opened 10 months ago

horizon-blue commented 10 months ago

Motivation

I hate to do this, but it looks like the compiler upgrade in PyTorch 2.0 somehow broke the pre-existing NNC usage in Bean Machine. Therefore, the algorithms that have NNC enabled by default are no longer working once we upgrade to PyTorch 2.0.

Until we figure out what's going on with the compiler, let's turn off NNC by default so that our tests can pass under PyTorch 2.0.

Changes proposed

Test Plan

If CI pass then we should be good.

Types of changes

Checklist

horizon-blue commented 10 months ago

I'm having trouble reproducing the failing test_constrained_positive_reals test on my machine, though I will take a closer look at a later time.