search

facebookresearch / clevr-dataset-gen

A Diagnostic Dataset for Compositional Language and Elementary Visual Reasoning
Other
577 stars 204 forks source link

Added some changes for blender 2.8+ #30

Open pjuangph opened 3 years ago

pjuangph commented 3 years ago

The only thing I failed to change was moving objects to a different layer. It's not a simple as obj.data.layer[2]=True anymore I commented out some lines of code. Please help me fix the remaining issues.

facebook-github-bot commented 3 years ago

Hi @pjuangph!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

pjuangph commented 3 years ago

I just signed your CLA

facebook-github-bot commented 3 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

guicho271828 commented 3 years ago

This isn't backward-compatible.

sweeneychris commented 3 years ago

I found that I also had to add these lines to the render_shadeless function:

bpy.context.scene.display.shading.light = 'FLAT'
bpy.context.scene.display.render_aa = 'OFF'