Open JensNevens opened 6 years ago
I have seen similar issues with question generation. My solution is to change the last lines in the main
function to the following
for q in questions:
for f in q['program']:
f['value_inputs'] = f['side_inputs'] if 'side_inputs' in f else []
Not sure why this would solve the issue though
Hello
I have generated a series of images and questions using the scripts in this repository. For the question generation, I have only used the
one hop
template. I think that some of the functional programs in the output JSON file are missing some information.Here is an example:
Shouldn't the first
filter_shape
function have["cube"]
asvalue_inputs
?This issue is not only restricted to
shape
, it also applies tosize
,color
andmaterial
. Also, the issue is not limited to questions that start withThere is a...
. Here is a second example:In this example, the first
filter_size
is missing["tiny"]
asvalue_inputs
and the firstfilter_color
is missing["brown"]
asvalue_inputs
.In both sentences, the
filter
functions later in the program do contain the correctvalue_inputs
.