Fix instrument_checkpoint swallow exception

facebookresearch / d2go

D2Go is a toolkit for efficient deep learning

Apache License 2.0

829 stars 197 forks source link

Closed jaconey closed 1 year ago

jaconey commented 1 year ago

Summary: ContextDecorator won't raise exception in __exit__. We have to manually re-raise it. Otherwise, the exception will be silently discarded.

Differential Revision: D47454999

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D47454999

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D47454999

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D47454999

facebook-github-bot commented 1 year ago

This pull request has been merged in facebookresearch/d2go@461b6a8021b6172df962bb6d83612010fe08eabe.