remove logging using logger at exit

facebookresearch / d2go

D2Go is a toolkit for efficient deep learning

Apache License 2.0

826 stars 197 forks source link

remove logging using logger at exit #628

Closed stephenyan1231 closed 8 months ago

stephenyan1231 commented 8 months ago

Summary: At the exit, file descriptor in the logger for info level logging has already been closed. Calling logger.info() will raise an exception. Thus, we remove it.

Reviewed By: ayushidalmia

Differential Revision: D50488097

facebook-github-bot commented 8 months ago

This pull request was exported from Phabricator. Differential Revision: D50488097

facebook-github-bot commented 8 months ago

This pull request was exported from Phabricator. Differential Revision: D50488097

facebook-github-bot commented 8 months ago

This pull request was exported from Phabricator. Differential Revision: D50488097

facebook-github-bot commented 8 months ago

This pull request has been merged in facebookresearch/d2go@b18c078a462d2eb0886cbf23b919e2ab360de049.