facebookresearch / darkforestGo

DarkForest, the Facebook Go engine.
Other
2.1k stars 325 forks source link

'simpleko' dcnn feature issue ? #19

Open lemonsqueeze opened 7 years ago

lemonsqueeze commented 7 years ago

Hi,

I was looking at the input features for the dcnn and it looks like the simpleko feature actually returns the player's stones (like the stones feature).

in board.lua:

function board.get_stones(b, player)
    local stones = torch.FloatTensor(19, 19)
    C.GetStones(b, player, stones:data())
    return stones
end

function board.get_simple_ko(b, player)
    local simple_ko = torch.FloatTensor(19, 19)
    C.GetStones(b, player, simple_ko:data())
    return simple_ko
end

Maybe GetSimpleKo() was meant instead of GetStones() ?

yuandong-tian commented 7 years ago

Thanks for finding the bug! This indeed affects the feature used in DCNN. Then I need to retrain the model for a better performance.