search

facebookresearch / demucs

Code for the paper Hybrid Spectrogram and Waveform Source Separation
MIT License
8.37k stars 1.07k forks source link

Use mps by default if available #575

Open elidourado opened 11 months ago

elidourado commented 11 months ago

Use Apple Silicon's Metal Performance Shaders if available. This can already be done using "-d mps" but changing this configuration makes it available by default. In my testing this makes source separation about 8x faster on an M2 MBP.

facebook-github-bot commented 11 months ago

Hi @elidourado!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

CarlGao4 commented 11 months ago

Line too long! It won't pass the linter

facebook-github-bot commented 11 months ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

adefossez commented 11 months ago

I'm no longer working at Meta, so this PR won't get merged :) New PRs should go over there: https://github.com/adefossez/demucs

elidourado commented 11 months ago

Thanks, I put in a PR over there as well, in case there's any hope of a new release. Appreciate it.