A question about visualization

facebookresearch / denoised_mdp

Open source code for paper "Denoised MDPs: Learning World Models Better Than the World Itself"

Other

134 stars 11 forks source link

Closed ShiguangSun closed 1 year ago

ShiguangSun commented 1 year ago

I find that there exists the "floor" in the visualization image when I run a video background experiment. Like this: test_episode_0005000

And I notice that the video shown in the repository has no floor:

Is the question I meet normal？ Thanks.

ssnl commented 1 year ago

Hi @ShiguangSun ! Thanks so much for bringing this to my attention. There is indeed a bug in setting the background removal mode for walker walk. It only exists in this public implementation, and now is fixed in https://github.com/facebookresearch/denoised_mdp/commit/1f3b4b38324a762434c7097d3fd2fc84ca4cc909.

This does not only affect visualization but training as well... I'm really sorry about the bug.

ShiguangSun commented 1 year ago

Ok，thanks.