facebookresearch / denoised_mdp

Open source code for paper "Denoised MDPs: Learning World Models Better Than the World Itself"
Other
134 stars 11 forks source link

AssertionError when Results Directory does not exist #3

Closed sebimarkgraf closed 2 years ago

sebimarkgraf commented 2 years ago

When trying the code for the first time, the validation in the config throws an error due to the default path not existing.

Traceback (most recent call last):
  File "/home/sebbo/Projekte/denoised_mdp/main.py", line 48, in <module>
    from config import InstantiatedConfig, to_config_and_instantiate
  File "/home/sebbo/Projekte/denoised_mdp/config.py", line 227, in <module>
    cs.store(name='config', node=Config())
  File "<attrs generated init config.Config>", line 24, in __init__
  File "/home/sebbo/Projekte/denoised_mdp/config.py", line 80, in exists_path
    assert os.path.exists(value)
AssertionError

This could be made easier by automatically creating the directory when it does not exist.

ssnl commented 2 years ago

Added results directory at default path.