search

facebookresearch / detectron2

Detectron2 is a platform for object detection, segmentation and other visual recognition tasks.
https://detectron2.readthedocs.io/en/latest/
Apache License 2.0
30.12k stars 7.42k forks source link

replace hcc with correct macro for rocm platforms #5192

Closed gurpreet-dhami closed 8 months ago

gurpreet-dhami commented 8 months ago

Summary: __HIP_PLATFORM_HCC__ is now removed from rocm-6.0 and should be __HIP_PLATFORM_AMD__.

Thanks for your contribution!

If you're sending a large PR (e.g., >100 lines), please open an issue first about the feature / bug, and indicate how you want to contribute.

We do not always accept features. See https://detectron2.readthedocs.io/notes/contributing.html#pull-requests about how we handle PRs.

Before submitting a PR, please run dev/linter.sh to lint the code.

facebook-github-bot commented 8 months ago

Hi @gurpreet-dhami!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 8 months ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

jeffdaily commented 8 months ago

@ezyang perhaps to land this trivial PR?

facebook-github-bot commented 8 months ago

@ezyang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 8 months ago

@ezyang merged this pull request in facebookresearch/detectron2@864913f0e57e87a75c8cc0c7d79ecbd774fc669b.