search

facebookresearch / detectron2

Detectron2 is a platform for object detection, segmentation and other visual recognition tasks.
https://detectron2.readthedocs.io/en/latest/
Apache License 2.0
29.3k stars 7.32k forks source link

Exclude tools from packaging #5283

Open tkkcc opened 1 month ago

tkkcc commented 1 month ago

current packaging includes tools, this cause namespace pollution such that user can't import their own tools module normally in their project.

this patch exclude tools, but only works for pip install without -e. it's better to move tools or setup.py into detectron2 subfolder.

related: https://github.com/facebookresearch/detectron2/issues/5205 https://github.com/facebookresearch/detectron2/issues/3934 https://github.com/pytorch/benchmark/commit/a599b49b9229522f67d42a8b3265e9a32ef9dcd0

facebook-github-bot commented 1 month ago

Hi @tkkcc!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!