search

facebookresearch / differentiable-robot-model

We are implementing differentiable models of robot manipulators, which allows us to learn typically assumed to be known models of robots for control and motion planning.
MIT License
240 stars 36 forks source link

Remove explicitly setting torch.float32 as the dtype in urdf_utils.py functions #41

Open thomasweng15 opened 2 years ago

thomasweng15 commented 2 years ago

I was getting an error for torch tensor types that was fixed by eliminating explicitly setting torch.float32 as the dtype in urdf_utils.py function calls.

test_devices.py passes with these changes.

thomasweng15 commented 2 years ago

Tagging @exhaustin @fmeier

I ran the pytest suite and verified that all tests, not just test_devices.py, still pass.

facebook-github-bot commented 1 year ago

Hi @thomasweng15!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!