search

facebookresearch / dlrm

An implementation of a deep learning recommendation model (DLRM)
MIT License
3.75k stars 837 forks source link

Decouple train/val/test code by using separate pipelines for each. Remove --change_lr since --lr_scheduler can perform same behavior. #291

Closed samiwilf closed 1 year ago

samiwilf commented 1 year ago

Summary: Decouple train/val/test code by using separate pipelines for each. Remove --change_lr since --lr_scheduler can perform same behavior. Cleanup comments and code.

Differential Revision: D41264865

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D41264865

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D41264865

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D41264865

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D41264865

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D41264865

facebook-github-bot commented 1 year ago

@samiwilf has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@samiwilf has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@samiwilf has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@samiwilf has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@samiwilf has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

samiwilf commented 1 year ago

This has been merged. See https://github.com/facebookresearch/dlrm/commit/37da857a406655fbf3218a94530f97deb6793769