search

facebookresearch / dora

Dora is an experiment management framework. It expresses grid searches as pure python files as part of your repo. It identifies experiments with a unique hash signature. Scale up to hundreds of experiments without losing your sanity.
MIT License
262 stars 24 forks source link

`grids/` without `__init__.py` crashes #26

Closed louismartin closed 2 years ago

louismartin commented 2 years ago

https://github.com/facebookresearch/dora/blob/a0a65582ca416d022e0251c711510fc8f99280e7/dora/grid.py#L99

grids.__file__ is None if there is no __init__.py.

adefossez commented 2 years ago

making the __init__.py seems like the most straightforward fix. Allowing for packages without an __init__.py just makes everything more complex for no real gain as far as I can tell.