Dora outputs dir broken when git_save: true

facebookresearch / dora

Dora is an experiment management framework. It expresses grid searches as pure python files as part of your repo. It identifies experiments with a unique hash signature. Scale up to hundreds of experiments without losing your sanity.

MIT License

262 stars 24 forks source link

Dora outputs dir broken when git_save: true #30

Closed louismartin closed 2 years ago

louismartin commented 2 years ago

🐛 Bug Report

Since I used git_save: true the dora output dir is nested into the saved code dir. I.e. my checkpoints are saved here: dora_outputs/codes/73345a0f0c11882824e3c9d2d354a1c1b82098d6/dora_outputs/xps/6658f617/lightning_logs/ instead of here dora_outputs/xps/6658f617/lightning_logs/.

279571536_478615730681942_7232181962064291643_n 279500923_1080774419172504_4165265806523926916_n

Your Environment

Python version: 3.9
Operating system: Ubuntu 20+

louismartin commented 2 years ago

Ok my bad it was actually due a fix that I committed in my fork https://github.com/louismartin/dora/commit/4dd4f9fe5c55dfb4e01bea6d1045bc46e1ae0cd4 that aimed at fixing #28 As I defined an absolute path for the dora dir that is relative to the decorated main file, it was not considered by to_absolute. So far I have rolled back my changes, but maybe in the future it would be worth having to_absolute change any absolute path that are subfolders of the clone.

Feel free to close.