facebookresearch / esm

Evolutionary Scale Modeling (esm): Pretrained language models for proteins
MIT License
3.16k stars 627 forks source link

Allow ESMFold run w/ pre-downloaded models #329

Closed YaoYinYing closed 1 year ago

facebook-github-bot commented 1 year ago

Hi @YaoYinYing!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 1 year ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

tomsercu commented 1 year ago

@YaoYinYing could you try the following:

Would that be satisfactory?

All the load_from_local_path() was more for debugging/development purpose and ideally we stick to standard structure of downloading & caching model paths as much as possible.

YaoYinYing commented 1 year ago

@tomsercu Thanks for your hints! Yes. It makes sense to use torch.hub.set_dir() for setting model_pth to pre-downloaded weights. One could download these files into a subdir checkpoints under model_pth. I will consider another PR with my latest changes!