Closed adrienchaton closed 1 year ago
Hi @adrienchaton thanks for pointing that out! We would most definitely welcome a PR to improve this. Also the notebooks could easily incorporate it once it's implemented. Thank you!
I have my own fork of IF1 with device support in model.sample
, util.score_sequence
, multichain_util.score_sequence_in_complex
, and multichain_util.ssample_sequence_in_complex
. Happy to get a PR drafted for this tomorrow!
@naailkhan28 I let you do the PR, let me know if I can give a hand also it would be good to fix get_encoder_output and get_encoder_output_for_complex at the same time because there too the device is not configured
Hi all, sorry for the delays - PR #386 should address this, with device support for model.sample
as well as using the model device for get_encoder_output
and multichain sample
too.
Hello,
This is related to https://github.com/facebookresearch/esm/pull/317 ; none of the main functionalities of esm_if1_gvp4_t16_142M_UR50 seem to run on GPU. This applies to model.sample ; esm.inverse_folding.util.score_sequence and esm.inverse_folding.util.get_encoder_output.
This is a bit unfortunate and can be resolved rather easily ... Do you plan to fix this please ? Or would you like a PR ? If not, is there a specific reason not to run these methods on GPU ? We could do an allclose test and verify that results are consistent.
Thanks !