facebookresearch / fairo

A modular embodied agent architecture and platform for building embodied agents
MIT License
851 stars 91 forks source link

"point to the left of the cow" fails #112

Open snyxan opened 3 years ago

snyxan commented 3 years ago

Type of Issue

Select the type of issue:

Description

The logical form from nsp didn't show POINT as action type, thus it fails at mc side. Here's the error log:

2021-02-07 00:06:20,249 [loco_mc_agent.py:262 - controller_step() INFO]: Incoming chat: ['f97fcb676d9a0f60ca9032e08116bf481fc9a2ff8ede7153ceabd2dd1ef7ee4d:863adbb93c6a44eda6becaff276e750a' -> point to the left of the cow]
2021-02-07 00:06:22,456 [dialogue_manager.py:87 - step() INFO]: Dialogue stack pre-run_model: []
2021-02-07 00:06:22,457 [nsp_dialogue_manager.py:224 - get_logical_form() INFO]: Querying the semantic parsing model
2021-02-07 00:06:23,247 [nsp_dialogue_manager.py:231 - get_logical_form() INFO]: chat before lemmatization "point to the left of the cow"
2021-02-07 00:06:23,277 [nsp_dialogue_manager.py:234 - get_logical_form() INFO]: chat after lemmatization "point to the left of the cow"
2021-02-07 00:06:23,277 [nsp_dialogue_manager.py:238 - get_logical_form() INFO]: ttad pre-coref "point to the left of the cow" -> {'dialogue_type': 'HUMAN_GIVE_COMMAND', 'action_sequence': [{'action_type': 'DANCE', 'location': {'reference_object': {'filters': {'triples': [{'pred_text': 'has_name', 'obj_text': 'cow'}]}}, 'relative_direction': 'LEFT'}}]}
2021-02-07 00:06:23,278 [nsp_dialogue_manager.py:248 - get_logical_form() INFO]: logical form before grammar update "{'dialogue_type': 'HUMAN_GIVE_COMMAND', 'action_sequence': [{'action_type': 'DANCE', 'location': {'reference_object': {'filters': {'triples': [{'pred_text': 'has_name', 'obj_text': 'cow'}]}}, 'relative_direction': 'LEFT'}}]}
2021-02-07 00:06:23,278 [nsp_dialogue_manager.py:249 - get_logical_form() INFO]: logical form after grammar fix "{'dialogue_type': 'HUMAN_GIVE_COMMAND', 'action_sequence': [{'action_type': 'DANCE', 'location': {'reference_object': {'filters': {'triples': [{'pred_text': 'has_name', 'obj_text': 'cow'}]}}, 'relative_direction': 'LEFT'}}]}"
2021-02-07 00:06:23,279 [nsp_dialogue_manager.py:169 - handle_logical_form() INFO]: logical form post-coref "ae38f8f552bc8be1cadfabec4b73a1afbba4121809dcc452ccbdb84b93f844d4:ddbabddc75f5418099598d2aa7a85c19" -> {'dialogue_type': 'HUMAN_GIVE_COMMAND', 'action_sequence': [{'action_type': 'DANCE', 'location': {'reference_object': {'filters': {'triples': [{'pred_text': 'has_name', 'obj_text': 'cow'}]}}, 'relative_direction': 'LEFT'}}]}

Steps to reproduce

In MC, give this command to the bot: "point to the left of the cow".

Rebecca-Qian commented 3 years ago

@snyxan Can you list these issues on the model trackers? The links are updated in the droidlet-semantic parser issues group

kavyasrinet commented 3 years ago

can we also add this to ground truth using the tool ?