facebookresearch / fairo

A modular embodied agent architecture and platform for building embodied agents
MIT License
847 stars 90 forks source link

Parser Issues - 03/02 #211

Open Rebecca-Qian opened 3 years ago

Rebecca-Qian commented 3 years ago

Type of Issue

Select the type of issue:

Description

Thread for model failures associated with the semantic parser released on 03/02.

Please do not create separate issues for model failures, and instead post here. If you see other types of issues eg. performance regression, create a new issue and link it here.

Use the Autocomplete labelling tool to add failed commands to ground truth. Instructions are here: https://github.com/facebookresearch/droidlet/blob/main/tools/annotation_tools/template_tool/AUTOCOMPLETE_README.md

snyxan commented 3 years ago

INFO:root:Incoming chats: ['<dashboard> build a small cube']
2021-03-08 05:11:11,458 [loco_mc_agent.py:264 - controller_step() INFO]: Incoming chats: ['<dashboard> build a small cube']
INFO:root:Querying the semantic parsing model
2021-03-08 05:11:12,687 [nsp_dialogue_manager.py:332 - get_logical_form() INFO]: Querying the semantic parsing model
INFO:root:logical form post-coref "d58b9b3de449157e7fce36884250affdf023964d90e7b007ef6aed2dca881354:cabbaf196f3347d28eb472e8aac1c04d" -> {'dialogue_type': 'HUMAN_GIVE_COMMAND', 'action_sequence': [{'action_type': 'BUILD', 'schematic': {'triples': [{'pred_text': 'has_name', 'obj_text': 'build'}, {'pred_text': 'has_tag', 'obj_text': 'small'}], 'text_span': 'small cube'}}]}
2021-03-08 05:11:13,364 [nsp_dialogue_manager.py:171 - handle_logical_form() INFO]: logical form post-coref "d58b9b3de449157e7fce36884250affdf023964d90e7b007ef6aed2dca881354:cabbaf196f3347d28eb472e8aac1c04d" -> {'dialogue_type': 'HUMAN_GIVE_COMMAND', 'action_sequence': [{'action_type': 'BUILD', 'schematic': {'triples': [{'pred_text': 'has_name', 'obj_text': 'build'}, {'pred_text': 'has_tag', 'obj_text': 'small'}], 'text_span': 'small cube'}}]}
kavyasrinet commented 3 years ago

Has this been fixed ? Looks like an old model tracker.