Assign self.norm_type to input norm_type

facebookresearch / fairscale

PyTorch extensions for high performance and large scale training.

Other

3.18k stars 280 forks source link

Closed gtamer2 closed 9 months ago

gtamer2 commented 10 months ago

Fixes #1156

[x] Did you have fun?
- Make sure you had fun coding 🙃
[x] Did you read the contributor guideline?
[ ] Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
- [ ] N/A
[ ] Did you make sure to update the docs?
- [ ] N/A
[ ] Did you write any new necessary tests?
- [x] N/A
[ ] Did you update the changelog? (if needed)
- [x] N/A

TBD

brad-mengchi commented 9 months ago

Oh just saw your PR. Maybe let me approve and merge it. @gtamer2