facebookresearch / faiss

A library for efficient similarity search and clustering of dense vectors.

https://faiss.ai

MIT License

29.71k stars 3.5k forks source link

Open heemin32 opened 1 month ago

heemin32 commented 1 month ago

Summary

IndexBinaryHNSW and IndexBinaryIVF is blocking SearchParameters. Can we open it up? Will there be any issue that I am not aware of? https://github.com/facebookresearch/faiss/blob/main/faiss/IndexBinaryHNSW.cpp#L192

mdouze commented 1 month ago

what do you mean with "blocking"?

heemin32 commented 1 month ago

what do you mean with "blocking"?

    FAISS_THROW_IF_NOT_MSG(
            !params, "search params not supported for this index");

mdouze commented 1 month ago

Right, search parameters are not supported for most binary indexes. Enabling support is relatively simple, feel free to submit a PR.