search

facebookresearch / faiss

A library for efficient similarity search and clustering of dense vectors.
https://faiss.ai
MIT License
31.64k stars 3.65k forks source link

remove compile options label from gbench #3834

Closed mengdilin closed 2 months ago

mengdilin commented 2 months ago

Summary: Looks like ServiceLab does not handle any metric that is not integer: https://fburl.com/code/chqi5hcr The current experiments are erroring with the message https://fburl.com/servicelab/99s69hbf:

ERROR:windtunnel.benchmarks.gbench_benchmark_runner.gbench_benchmark_runner:exception occurred while processing benchmark (this usually means a benchmark is misconfigured) faiss/perf_tests/scalar_quantizer_distance_test1/bench_scalar_quantizer_distance:QT_bf16_128d_2000n/iterations invalid literal for int() with base 10: 'OPTIMIZE AVX2 '
Traceback (most recent call last):
  File "windtunnel/benchmarks/gbench_benchmark_runner/gbench_benchmark_runner.py", line 116, in parse_gbench_results
    int(entry[metric_name]),
ValueError: invalid literal for int() with base 10: 'OPTIMIZE AVX2 '

Removing the label that's causing the failure. We can track the optimization mode via experiment names, or a dummy counter name in the future as I roll out multi-platform experiments.

Differential Revision: D62166280

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D62166280

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D62166280

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D62166280

facebook-github-bot commented 2 months ago

This pull request has been merged in facebookresearch/faiss@1cafc711e4f6c025e30303c17bb54ecf10f04cda.