facebookresearch / faiss

A library for efficient similarity search and clustering of dense vectors.

https://faiss.ai

MIT License

31.64k stars 3.65k forks source link

Add explicit instanciations of `search_dispatch_implem` #3860

Closed JAicewizard closed 2 months ago

JAicewizard commented 2 months ago

Since commit 32f0e8cf92cd2275b60364517bb1cce67aa29a55 (https://github.com/facebookresearch/faiss/pull/3190) faiss fails to build on gcc7.

For some reason gcc7 needs these explicit instanciations (or rather, for some reason later versions are OK without them). This commit partially revers that commit, adding back the explicit instanciations.

facebook-github-bot commented 2 months ago

Hi @JAicewizard!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 2 months ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

alexanderguzhva commented 2 months ago

@JAicewizard Could you please share your use case, because gcc7 is quite old? Thanks.

JAicewizard commented 2 months ago

GCC7 might be quite old, however build systems that target old versions of glibc often use very old compilers. Many build environments that support old systems are also build on old systems, one I am working with still uses GCC4 (although it should be updated soon). Previous versions of faiss worked on GCC4 even (maybe even earlier, but that is the latest I tested).

Since this is just a small change without a big maintenance burden, I hope it would be accepted.

mdouze commented 2 months ago

Agreed. We should accommodate as old compilers as possible.

facebook-github-bot commented 2 months ago

@mnorris11 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 months ago

@mnorris11 merged this pull request in facebookresearch/faiss@6da99524693a28c397cbe2144ab04f9287baa87b.