FIx a bug for a non-simdlib code of ResidualQuantizer

facebookresearch / faiss

A library for efficient similarity search and clustering of dense vectors.

https://faiss.ai

MIT License

30.69k stars 3.58k forks source link

Closed alexanderguzhva closed 1 week ago

alexanderguzhva commented 1 week ago

This causes an access violation error.

The reason why this was not caught in unit tests for AVX/NEON is that this code branch is unlikely to be used.

The reason why this was not caught in unit tests for a plain non-SIMD binary is unclear.

More ResidualQuantizer patches to follow.

facebook-github-bot commented 1 week ago

@mnorris11 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 week ago

@mnorris11 merged this pull request in facebookresearch/faiss@317bd0055b0ea57c7762c25e62497116a21dd330.

mnorris11 commented 1 week ago

Thanks for finding it and for the fix!