search

facebookresearch / faiss

A library for efficient similarity search and clustering of dense vectors.
https://faiss.ai
MIT License
31.7k stars 3.66k forks source link

Add reverse factory string util, add StringIOReader, add centralized JK #3879

Closed mnorris11 closed 2 months ago

mnorris11 commented 2 months ago

Summary:

  1. Adds JK faiss/telemetry:use_faiss_telemetry_core to the top level logging util in wrapper_logging_utils.h. This is currently set to false. I plan to deprecate the other knobs under https://www.internalfb.com/intern/justknobs/?name=faiss%2Ftelemetry and just use one, as Unicorn can't really have their own JK easily (they subclass a lot of FAISS classes too).
  2. Copied StringIOReader from Unicorn to telemetry wrapper in io.h. This will be deleted from Unicorn in the follow up diff.
  3. Updated Laser tests to reflect correct index_read factory string changes.
  4. Adds reverse_index_factory. More tests for it in subsequent diff.

Differential Revision: D62670316

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D62670316

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D62670316

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D62670316

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D62670316

facebook-github-bot commented 2 months ago

This pull request has been merged in facebookresearch/faiss@0660b2316bc5e95f1cb73f1a236a8d27e4717ca1.