search

facebookresearch / faiss

A library for efficient similarity search and clustering of dense vectors.
https://faiss.ai
MIT License
31.64k stars 3.65k forks source link

fix hnsw unit test in opt mode #3919

Closed mengdilin closed 1 month ago

mengdilin commented 1 month ago

Summary: These tests are passing successfully in dev mode during my local development when I added them but I recently noticed they are failing on contbuild which is running them in opt/mode: https://www.internalfb.com/intern/test/281475152762853/

Upon further inspection, 2 of these were from floating point comparisons which we can fix with EXPECT_NEAR. The another one stems from indeterminism of the results in opt mode, so we will relax the test until we figure out a way to deal with the indeterminism

Reviewed By: junjieqi

Differential Revision: D63942329

facebook-github-bot commented 1 month ago

This pull request was exported from Phabricator. Differential Revision: D63942329

facebook-github-bot commented 1 month ago

This pull request has been merged in facebookresearch/faiss@be4fc8e5037867cd97f5a4beacf6039014df1743.