search

facebookresearch / faiss

A library for efficient similarity search and clustering of dense vectors.
https://faiss.ai
MIT License
31.58k stars 3.65k forks source link

Fix shadowed variable in faiss/IndexIVFAdditiveQuantizer.cpp #3958

Closed r-barnes closed 1 month ago

r-barnes commented 1 month ago

Summary: Our upcoming compiler upgrade will require us not to have shadowed variables. Such variables have a high bug rate and reduce readability, so we would like to avoid them even if the compiler was not forcing us to do so.

This codemod attempts to fix an instance of a shadowed variable. Please review with care: if it's failed the result will be a silent bug.

What's a shadowed variable?

Shadowed variables are variables in an inner scope with the same name as another variable in an outer scope. Having the same name for both variables might be semantically correct, but it can make the code confusing to read! It can also hide subtle bugs.

This diff fixes such an issue by renaming the variable.

Differential Revision: D64398701

facebook-github-bot commented 1 month ago

This pull request was exported from Phabricator. Differential Revision: D64398701

facebook-github-bot commented 1 month ago

This pull request has been merged in facebookresearch/faiss@68f66bc26ce2bc605624245b735f1c28f2460ee6.