Removing Manual Hipify Build Step

facebookresearch / faiss

A library for efficient similarity search and clustering of dense vectors.

https://faiss.ai

MIT License

31.63k stars 3.65k forks source link

Removing Manual Hipify Build Step #3962

Closed ItsPitt closed 1 month ago

ItsPitt commented 1 month ago

Called the hipify script at CMAKE configure time removing the need for the user to run it.
Now removes any .hip files left over when running the hipify script.
Cleaned up the hipify script to remove redundancy.

facebook-github-bot commented 1 month ago

@mnorris11 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

mnorris11 commented 1 month ago

For some reason Build / Linux x86_64 GPU w/ RAFT is failing both on this PR and some others due to a segfault in python tests. Strange that it did not fail during the nightly build though. Looking into it

facebook-github-bot commented 1 month ago

@mnorris11 merged this pull request in facebookresearch/faiss@f9a01c65c08c4ddd2b194d4f92f6cb20d0b52705.