search

facebookresearch / fastMRI

A large-scale dataset of both raw MRI measurements and clinical MRI images.
https://fastmri.org
MIT License
1.3k stars 372 forks source link

Fix out_path argument and describe TOOLPATH pointing location #135

Closed gabrielziegler3 closed 3 years ago

gabrielziegler3 commented 3 years ago

Fix output path mentioned in the CS example README to match the one required in run_bart.py.

Changed from output_path to out_path and detailed a bit more the TOOLBOX_PATH environmental variable setting.

Both the CS and Zero Filled experiments use out_path whilst UNet and VarNet use output_path. Maybe we could standardize into one of them?

facebook-github-bot commented 3 years ago

Hi @gabrielziegler3!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 3 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!