search

facebookresearch / fastMRI

A large-scale dataset of both raw MRI measurements and clinical MRI images.
https://fastmri.org
MIT License
1.3k stars 372 forks source link

fixes complex_abs & complex_abs_sq missmatch #154

Closed wdika closed 3 years ago

wdika commented 3 years ago

Pretty important bug that applies to significant computations across the repo,

facebook-github-bot commented 3 years ago

Hi @wdika!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 3 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

wdika commented 3 years ago

Hello @wdika, thank you for submitting a pull request.

For some reason, CircleCI didn't run on this PR, but this PR actually introduces bugs that break some tests because the current behavior is intended. The docstrings of the functions make it pretty clear that complex_abs should take the square root and complex_abs_sq returns the squared complex absolute value.

Thanks for the reply @mmuckley I realized after that this change would break other things. Intuitively I would think the opposite, which took me some time to realize and I thought it should be changed. But since you are saying it makes sense this way please close my pr.