search

facebookresearch / fastMRI

A large-scale dataset of both raw MRI measurements and clinical MRI images.
https://fastmri.org
MIT License
1.29k stars 370 forks source link

Workaround for h5py memory leak #227

Closed soumickmj closed 2 years ago

facebook-github-bot commented 2 years ago

Hi @soumickmj!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 2 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

soumickmj commented 2 years ago

Hi @mmuckley That's strange. h5py dataset does not have a copy method, but when "hf["kspace"][dataslice]" is called it becomes numpy.ndarray which is then having a copy method. It is working fine for me with this code: image

Converting to numpy explicitly and then copy: I tried earlier and that did not resolve the issue for me as well. But directly calling copy is working for me.

I wonder what's the difference then. What's the versinon of Python and h5py are you using?

mmuckley commented 2 years ago

This is the full error:

  File "/private/home/mmuckley/projects/fastmri/code/fastMRI/fastmri/data/mri_data.py", line 350, in __getitem__
    mask = np.asarray(hf["mask"].copy()) if "mask" in hf else None
AttributeError: 'Dataset' object has no attribute 'copy'

So the issue might be that you're calling it on the test set and returning None.

We actually have a unit test for __getitem__ here. Could you make sure that your code is passing all lints and unit tests before I test again? You should be able to get unit tests on your fork by renaming your branch to main.

mmuckley commented 2 years ago

Closing due to inactivity.