search

facebookresearch / fastMRI

A large-scale dataset of both raw MRI measurements and clinical MRI images.
https://fastmri.org
MIT License
1.32k stars 374 forks source link

Filter function based on metadata for Datasets #257

Closed zaccharieramzi closed 2 years ago

zaccharieramzi commented 2 years ago

This should close #256

For the unit test I would like to modify the created temporary data, but don't know whether I can do that.

zaccharieramzi commented 2 years ago

@mmuckley Yes ofc always happy to help.

I am just wondering whether I should also apply the example -> sample change to the banding_removal subfolder? It has a lot of duplicated code atm, so not sure it's in a steady state anyway, no?

Also, I though that raw_sample was a bit more speaking than sample, because it allowed to make the difference with the sample classes defined in transforms.py. WDYT?

Btw, not complaining but just for future reference, it's ofc easier to refactor using VSCode, but I still needed to change some of the references + naming of other related variables like when iterating through the list.

mmuckley commented 2 years ago

Hello @zaccharieramzi no worries - we can merge this at the moment if you prefer not to make the API change and do API stuff later.

You don't need to worry about the banding_removal folder at all - that is maintained separately and we haven't incorporated it into the main repo.

zaccharieramzi commented 2 years ago

Haha there was a misunderstanding: I did the API change. I just had some questions regarding how I went about it.