search

facebookresearch / fastMRI

A large-scale dataset of both raw MRI measurements and clinical MRI images.
https://fastmri.org
MIT License
1.28k stars 371 forks source link

define 'raw_sample_filter' before use #260

Closed ZhengguoTan closed 1 year ago

ZhengguoTan commented 1 year ago

Dear fastMRI developers,

Please consider whether this commit is necessary.

I look forward to contributing to this project.

Best Regards, Zhengguo Tan

facebook-github-bot commented 1 year ago

Hi @ZhengguoTan!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 1 year ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot commented 1 year ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

ZhengguoTan commented 1 year ago

Dear @mmuckley, thank you for your quick feedback. To my understanding, the test data partitions are already given in the if condition. Or may you be more specific what changes are needed?

Best Regards, Zhengguo

mmuckley commented 1 year ago

Hello @ZhengguoTan, the if statement covers if it's a test or challenge split and test_path is not none. So even if that check fails, the split could still be "val", "test" or "challenge". For example, when the test path is in the primary fastMRI data folder and the user does not need to specify test_path.

mmuckley commented 1 year ago

Closing due to inactivity and should have been fixed by 37ffc89309c941f00ac873f5dd9b6f537411cb10.