torch.eig is deprecated for a long time and is being removed

facebookresearch / fastMRI

A large-scale dataset of both raw MRI measurements and clinical MRI images.

https://fastmri.org

MIT License

1.28k stars 371 forks source link

torch.eig is deprecated for a long time and is being removed #266

Closed kit1980 closed 1 year ago

kit1980 commented 1 year ago

PyTorch's torch.eig was deprecated since version 1.9 and is being removed by https://github.com/pytorch/pytorch/pull/70982. Please use the torch.linalg.eig function instead if you want your code to continue to work with the latest PyTorch.

Affected file: https://github.com/facebookresearch/fastMRI/blob/37ffc89309c941f00ac873f5dd9b6f537411cb10/banding_removal/fastmri/data/transforms.py#L507

lezcano commented 1 year ago

If the covariance is Hermitian (as it should be) you should use linalg.eigh.

mmuckley commented 1 year ago

@adefazio Could you submit a PR to fix this deprecation?

adefazio commented 1 year ago

The complex_whiten function appears to not be used so I'm going to remove it rather that fix it, does that make sense?

mmuckley commented 1 year ago

That sounds good to me.