search

facebookresearch / fastMRI

A large-scale dataset of both raw MRI measurements and clinical MRI images.
https://fastmri.org
MIT License
1.28k stars 371 forks source link

add feature varnet #340

Open GiannakopoulosIlias opened 1 month ago

GiannakopoulosIlias commented 1 month ago

Added a new folder in fastmri_examples which includes the new modules for feature varent and ablations. Added a new model file (feature_varnet) in fastmri/models which includes the new models. Updated markdowns to include the new reference.

facebook-github-bot commented 1 month ago

Hi @GiannakopoulosIlias!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 1 month ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

mmuckley commented 1 month ago

Also @GiannakopoulosIlias it looks like the PR is failing some linter tests. Could you also fix those?

mmuckley commented 3 weeks ago

@GiannakopoulosIlias some tests still aren't passing. Please make sure you're using the correct version of black on your code.

mmuckley commented 3 weeks ago

@GiannakopoulosIlias the message about Jupyter can be ignored. You only need to pip install black with the right version listed in the message.

GiannakopoulosIlias commented 3 weeks ago

@GiannakopoulosIlias the message about Jupyter can be ignored. You only need to pip install black with the right version listed in the message.

Should be okay now, thanks!

mmuckley commented 3 weeks ago

Hello @GiannakopoulosIlias, now it looks like there are errors with type annotations with mypy.

If there are too many to deal with, you could move feature_varnet.py into the examples folder. Then you should be able to commit the code without fixing everything.

GiannakopoulosIlias commented 3 weeks ago

Hello @GiannakopoulosIlias, now it looks like there are errors with type annotations with mypy.

If there are too many to deal with, you could move feature_varnet.py into the examples folder. Then you should be able to commit the code without fixing everything.

I will try to adjust them tomorrow. They look many but I think most of them are the same error for all different model ablations.