search

facebookresearch / fastText

Library for fast text representation and classification.
https://fasttext.cc/
MIT License
25.92k stars 4.72k forks source link

bugfix: sort eigenvalues when computing pca vectors #1205

Open ajaech opened 3 years ago

ajaech commented 3 years ago

Summary: this is a bug reported on github https://github.com/facebookresearch/fastText/issues/1199

Differential Revision: D29413727

facebook-github-bot commented 3 years ago

This pull request was exported from Phabricator. Differential Revision: D29413727

facebook-github-bot commented 3 years ago

Hi @ajaech!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

safkotha commented 3 years ago

Let's make a better world.