facebookresearch / fastText

Library for fast text representation and classification.

https://fasttext.cc/

MIT License

25.83k stars 4.71k forks source link

Fixed msvc compiler error: error C2065: 'ssize_t': undeclared identi… #1279

Open ivlcic opened 2 years ago

ivlcic commented 2 years ago

Hi,

I've fixed compiler error with pip install on Windows OS.

Maybe this is not the right spot, but never the less: feel free to change.

facebook-github-bot commented 2 years ago

Hi @ivlcic!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 2 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot commented 2 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot commented 2 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

ivlcic commented 2 years ago

Fixes #1277

DoooReyn commented 1 year ago

Hi,

I've fixed compiler error with pip install on Windows OS.

Maybe this is not the right spot, but never the less: feel free to change.

It works. Thanks!

T1t4m1un commented 1 year ago

Hey @ivlcic, thanks a lot for your PR and the awesome solution to fix the problem I was facing! 🙌🎉 You rock!

By the way, I'm a bit surprised that the official team hasn't merged this patch even after a whole year. 😕 Any idea why they haven't merged it yet? It's such a valuable contribution! 🤔

Anyway, thanks again for your hard work! Let's hope we can get this patch merged soon! 🤞❤️

ivlcic commented 1 year ago

Any idea why they haven't merged it yet? It's such a valuable contribution!

I have no idea. Maybe it's in the wrong place or badly done. Anyway they should have fixed it already.