facebookresearch / fastText

Library for fast text representation and classification.
https://fasttext.cc/
MIT License
25.83k stars 4.71k forks source link

Add pyproject.toml to comply with PEP-518 #1292

Closed cfculhane closed 9 months ago

cfculhane commented 2 years ago

Adds pyproject.toml to comply with PEP-518, which fixes the building of the library by poetry - See https://github.com/python-poetry/poetry/issues/6113 . This is a copy of https://github.com/facebookresearch/fastText/pull/1270 , but I have signed the CLA.

mastern2k3 commented 2 years ago

@cfculhane haha good job, sorry for being unresponsive :+1:

Kavan72 commented 2 years ago

Any update here guys? :smiley:

cdpierse commented 2 years ago

Update on this would be great, the latest poetry update 1.2.0 is causing the package to break our unit tests as pybind11 is not getting built due to the introduction of this flag (--use-pep517) in poetry.

flaudarin-365talents commented 1 year ago

The installation seems to work fine. Made a test with this small pyproject.toml:

[tool.poetry]
name = "poetry-fasttext"
version = "0.0.0"
description = "Debug FastText install with poetry 1.2.0"
authors = ["Frédéric Laudarin"]
readme = "README.md"
packages = [{include = "poetry_fasttext"}]

[tool.poetry.dependencies]
python = "^3.9"
fasttext = {git = "https://github.com/cfculhane/fastText.git"}

[build-system]
requires = ["poetry-core"]
build-backend = "poetry.core.masonry.api"
ecly commented 1 year ago

@dmitryvinn would it be possible to expedite this PR, as it's causing headaches in a lot of usecases for fasttext?

KayhanB21 commented 1 year ago

@dmitryvinn would it be possible to expedite this PR, thanks!

FinnWoelm commented 1 year ago

Temporary workaround until this gets merged: poetry add git+https://github.com/cfculhane/fastText

aitorres commented 1 year ago

Hi! I'd also benefit from this PR being expedited, thanks!

cjuracek commented 1 year ago

@dmitryvinn +1 for an expedited PR, this would be greatly appreciated!

georgeseifada commented 1 year ago

+1 for this PR! 🙏

evrial commented 1 year ago

Fasttext is dead, someone should take ownership

grainnemcknight commented 1 year ago

Plus 1 for this. Does not work with poetry 1.3.2

nigelgutzmann commented 1 year ago

Temporary workaround until this gets merged: poetry add git+https://github.com/cfculhane/fastText

Looks like there's no master branch of on the repo at https://github.com/cfculhane/fastText (master is the default that poetry tries to use), so I had to install it by specifying the main branch:

poetry add git+https://github.com/cfculhane/fastText#main

But yes, obviously would be nice to have this merged directly into the official repo

vrdn-23 commented 1 year ago

If the changes are approved, can we merge this already?

KeshavSingh29 commented 1 year ago

Can we have some update on why Fasttext upgrade to include pep517 is so slow?

facebook-github-bot commented 9 months ago

@alexkosau has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 9 months ago

@alexkosau merged this pull request in facebookresearch/fastText@de458ddea42327cf314e69f9eef40d0ec02705ab.