facebookresearch / fmmax

Fourier modal method with Jax
MIT License
97 stars 10 forks source link

Improve vjp for `eig` #106

Closed mfschubert closed 7 months ago

mfschubert commented 7 months ago

As discussed #105, there is an opportunity to improve the eig vjp.

This PR makes the suggested change, which allows slight tightening of tolerances in some gradient calculation tests.